Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed trailing space in "Color randomizer " #67457

Merged

Conversation

im3dabasia
Copy link
Contributor

What?

In continuation of issue #59821, this comment by @ramonjd requested opening a PR to remove the trailing space in the "Color randomizer" string in lib/experiments-page.php.

Why?

The issue was re-opened to address it as it was not completely resolved; the string 'Color randomizer ' still contained a trailing space.

How?

Based on the suggestion, I have removed the trailing space from the string and am now raising a PR to address this.

Copy link

github-actions bot commented Dec 2, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Dec 2, 2024

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @im3dabasia! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Dec 2, 2024
Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you for the follow up!

@ramonjd ramonjd added the [Type] Code Quality Issues or PRs that relate to code quality label Dec 2, 2024
@Mamaduka Mamaduka added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Dec 2, 2024
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Dec 2, 2024
@Mamaduka Mamaduka merged commit d251f75 into WordPress:trunk Dec 2, 2024
68 of 69 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.9 milestone Dec 2, 2024
im3dabasia added a commit to im3dabasia/gutenberg that referenced this pull request Dec 4, 2024
Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
michalczaplinski pushed a commit that referenced this pull request Dec 5, 2024
Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants