Weight Link UI search results slightly towards Posts #67563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @shuttermuse. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +11 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 42b19eb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12273876269
|
getdave
requested review from
jeryj,
matiasbenedetto,
mikachan,
richtabor,
MaggieCabrera and
ajlende
packages/core-data/src/fetch/__experimental-fetch-link-suggestions.ts
Outdated
Show resolved
Hide resolved
getdave
force-pushed
the
try/weight-link-search-results-to-post-type
branch
from
eb80764 to
904c819
Compare
t-hamano
reviewed
Dec 11, 2024
| * score between 0 and 1, where 1 is a perfect match. | ||
| * We sort by scoring each result, where the score is a combination of the number of exact matches | ||
| * and sub-matches for tokens in the title that are also in the search query, divided by the total | ||
| * number of tokens in the title. This gives us a score between 0 and 1, where 1 is a perfect match. |
There was a problem hiding this comment.
This gives us a score between 0 and 1, where 1 is a perfect match.
I don't fully understand the scoring logic yet, but the score can be greater than 1, right? Is the actual maximum score 10?
There was a problem hiding this comment.
Overall i can now be greater than 1. We could tweak the whole thing to keep scores below 1 if that helps?
getdave
force-pushed
the
try/weight-link-search-results-to-post-type
branch
from
904c819 to
962e489
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Weights the Link UI search results slightly towards Posts
Closes #67561 and #63683
Why?
In general Link UI search Posts are likely the most relevant results. Therefore slightly weighting towards them is important when sorting the results.
How?
Apply a slight weighting factor in favour of sorting for
kind: post-typein search results.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast