Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Center background-position on block-cover-image #6760

Merged
merged 1 commit into from
May 20, 2018
Merged

Center background-position on block-cover-image #6760

merged 1 commit into from
May 20, 2018

Conversation

vtrpldn
Copy link

@vtrpldn vtrpldn commented May 15, 2018 •
edited
Loading

Description

Added a CSS line to properly center the bg on block cover image. Fix #6066.

How has this been tested?

Comparing centering changes to the ones @weavertheme posted on the respective issue.

Screenshots

Without background-position: center center;
no-center

With background-position: center center;
center

Types of changes

Add background-position: center center; at /core-blocks/cover-image/style.scss:4

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@vtrpldn vtrpldn changed the title Center background-position on block-cover-image (#6066) Center background-position on block-cover-image May 15, 2018
@danielbachhuber danielbachhuber added the Needs Design Feedback Needs general design feedback. label May 15, 2018
@ZebulanStanphill ZebulanStanphill mentioned this pull request May 15, 2018
Closed
@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label May 20, 2018
@karmatosed karmatosed self-requested a review May 20, 2018 16:48
karmatosed
karmatosed approved these changes May 20, 2018
View reviewed changes
Copy link
Member

@karmatosed karmatosed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see an argument for that the assumption of absolute centre is a step, but for now lets get this in. I'm approving and merging, thanks.

@karmatosed karmatosed merged commit 562c81f into WordPress:master May 20, 2018
@danielbachhuber danielbachhuber added this to the 3.0 milestone May 20, 2018
@vtrpldn vtrpldn deleted the fix/center-block-cover-image-background branch May 21, 2018 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karmatosed karmatosed karmatosed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vtrpldn @karmatosed @danielbachhuber