-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paragraph block text capitalize #67736
Paragraph block text capitalize #67736
Conversation
This reverts commit 63f81c1.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
@karthick-murugan, I don't think this is the right way to resolve this issue. Why?
Based on this, I think we can close this PR and try to track down the actual cause of the problem. |
@Mamaduka I agree with your assessment of this pull request. For additional context, I believe I identified the root cause. Unfortunately, I am unsure of the appropriate fix at this time, as it seems there is a fair bit of browser-specific complexity involved with the related code. |
Thanks for confirmation, @dcalhoun! |
What?
Fixes #63261
The issue was that the keyboard doesn't start capitalized (uppercase) in the paragraph block on iOS web.
Why?
The paragraph block did not show the keyboard in uppercase mode by default, causing an inconsistency with expected behavior when typing.
How?
The fix I’ve implemented ensures that the first letter of the paragraph text is capitalized when the block is focused. This is achieved by modifying the content of the paragraph block when the user starts typing. However, instead of making the entire keyboard input uppercase, I have implemented a solution where the first letter of the content is capitalized. The solution applies for all web and mobile devices and not only for IOS.
I’m not sure whether this is the ideal solution, as the original request was to ensure the keyboard itself starts in uppercase mode. I’d appreciate feedback from reviewers and commenters on whether this approach is acceptable or if a different solution is needed.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
REC-20241209171358.mp4