Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Block: Migrate Inquirer.js dependency to the new API #67877

Merged
merged 11 commits into from
Dec 19, 2024
Merged

Create Block: Migrate Inquirer.js dependency to the new API #67877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9ad54b7
Create Block: Update `inquirer` dependency to the latest version
gziolo Dec 12, 2024
e018817
Refactor first prompts to the new API
gziolo Dec 12, 2024
0462ef7
Fix TypeScript error
gziolo Dec 12, 2024
efccdbf
Refactor handling for plugin and block prompts
gziolo Dec 17, 2024
3ee3a67
Final touches after refactoring
gziolo Dec 17, 2024
7693886
Add changelog entry
gziolo Dec 17, 2024
26552cf
Refactor after rebasing with `trunk`
gziolo Dec 18, 2024
f5c8e69
Handling `ctrl+c` gracefully
gziolo Dec 18, 2024
bd1831d
Ensure that exiting the prompts is handled gracefully
gziolo Dec 19, 2024
4a99fdb
Add changelong entry to env package
gziolo Dec 19, 2024
29683d7
Update packages/create-block/lib/index.js
gziolo Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions bin/plugin/lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* External dependencies
*/
// @ts-ignore
const inquirer = require( 'inquirer' );
const { confirm } = require( '@inquirer/prompts' );
const fs = require( 'fs' );
const childProcess = require( 'child_process' );
const { v4: uuid } = require( 'uuid' );
Expand Down Expand Up @@ -97,14 +97,19 @@ async function askForConfirmation(
isDefault = true,
abortMessage = 'Aborting.'
) {
const { isReady } = await inquirer.prompt( [
{
type: 'confirm',
name: 'isReady',
let isReady = false;
try {
isReady = await confirm( {
default: isDefault,
message,
},
] );
} );
} catch ( error ) {
if ( error instanceof Error && error.name === 'ExitPromptError' ) {
console.log( 'Cancelled.' );
process.exit( 1 );
}
throw error;
}

if ( ! isReady ) {
log( formats.error( '\n' + abortMessage ) );
Expand Down
Loading
Loading