[core-data]: Fix TS types for user object #68045
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves two issues
getCurrentUser
selector's return type is set toET.User< 'edit' >
, which sets the incorrect return type which properties that don't exist on the current user object, for example,user.capabilities
. The return type should rather beET.User< 'view' >
because that is whatstate.currentUser
is, as mentioned in Convert core-data selectors from jsDoc annotations into TypeScript type signatures #40025 (comment)Here, you can see the difference between a current user (
users/me
) and a normal user (users/<id>
) object.user.capabilities
is set toRecord< string, string >
, which is incorrect. It should rather beRecord< string, boolean >
, because those capabilities come from here as pointed out in Core Data: TypeScript definitions for entity records. #38666 (comment)What?
getCurrentUser
selector.user.capabilities
to be a record of booleans instead of a record of strings.Why?
To fix the incorrect types
How?
By fixing the types
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast