Get active element within the iframe when restoring focus #68060
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jeryj
added
[Type] Bug
This was referenced Dec 17, 2024
|
Size Change: +10 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
jeryj
commented
Dec 17, 2024
| @@ -34,7 +30,6 @@ function ButtonBlockAppender( | |||
| if ( onSelect && typeof onSelect === 'function' ) { | |||
| onSelect( ...args ); | |||
| } | |||
| inserterButtonRef.current?.focus(); | |||
There was a problem hiding this comment.
This file is undoing work from https://github.com/WordPress/gutenberg/pull/64877/files#diff-4cdcf916fb8cf5f88b98cd9e95ab532d90369cd768334f7896720a2b85c018bbR37 which fixed moving focus to the appender, but did it without addressing the root issue.
ajlende
reviewed
Dec 18, 2024
ajlende
approved these changes
Dec 18, 2024
Co-authored-by: Alex Lende <alex+github.com@lende.xyz>
|
Flaky tests detected in 0c834eb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12398561057
|
|
Thanks for the fix! Would it be worth backporting this PR to WP 6.7.2? Because #67809 is an issue that first appeared in WP 6.7. |
cbravobernal
pushed a commit
that referenced
this pull request
Dec 20, 2024
…ocus (#68060) Co-authored-by: Alex Lende <alex+github.com@lende.xyz>
I think so, provided no bugs pop up as a result of it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67809
What?
useFocusReturndoesn't work for items within the editor canvas iframe. Focus is sent to theiframecanvas instead of the active element within it. This PR allows for focus to get restored to the active element within the canvas.Why?
This root focus loss issue has caused a lot of fragile hotfixes. After this is merged, we can remove them. Here's a list of ones I know about:
How?
The
useFocusReturnhook stores theactiveElementasfocusedBeforeMount.current, and then when popover/modal/etc closes, it returns focus to thefocusedBeforeMount.current.This works well unless the
activeElementis within aniframe(like the editor canvas). If the element is within aniframe, then thefocusedBeforeMount.currentis set as the iframe itself, not theactiveElementwithin theiframe.This PR checks to see if the
activeElementis aniframeand if theiframehas anactiveElementitself. If so, it sets theactiveElementwithin theiframeas thefocusedBeforeMount.current.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast