Use Badge component in page markers #68103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -46 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7af1658. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12411888493
|
|
It's curious that in the Pages list, the new badge style increases the height of It does however affect the page card. When the badge is visible it pushes the title out of alignment. Compare this PR (left) with trunk (right) below: 
To fix, perhaps we remove the |
|
Thanks for testing :) Nice catch! Removing the 2px padding will work when the page title is short, keeping the alignment. But when it's long and pushes the badge to a new line, then the page title is not aligned with the icon. Perhaps we can have a modifier for that particular badge where we unset the height so that's
|
|
Maybe this was fixed by #68115. Worth a rebase to check :) Edit: I suppose not since that change targeted _Block_Card. But perhaps the same technique can be used here? |
|
Thanks! Indeed, the rebase didn't fix it. But I took the same approach. Hopefully the choice of class name is ok. |
|
Nice, that seems to have solved it. This seems good to go from the design side :) |
tyxla
reviewed
Dec 19, 2024
Comment on lines
+36
to
+38
| .editor-post-card-panel__title-name { | ||
| padding: 2px 0; | ||
| } |
There was a problem hiding this comment.
I think this is unnecessary, because the wrapping .editor-post-card-panel__title.editor-post-card-panel__title already has display: flex; align-items: center, and it should center the nested title name vertically even without providing top/bottom padding.
There was a problem hiding this comment.
@tyxla Thanks for reviewing! Right, in that case is indeed not needed. I kept it for the particular case when the page title is long, and displayed in two lines.
That's when, without the padding, the vertical alignment ends up pushing the page title to the top and the alignment between title and icon is not working (please see the screenshot on the Panel title without 2px padding and long title column here).
If we're okay with not having that, I can remove it. The only thing is that it won't be in line with what we have for the Block Card.
There was a problem hiding this comment.
The proposed truncation is for the Badge, though. What's pushing things to be in two lines is the page title in this case.
There was a problem hiding this comment.
Ah, I see what you mean. I think it makes sense to keep the padding then 👍
| @@ -109,11 +111,11 @@ export default function PostCardPanel( { | |||
| className="editor-post-card-panel__title" | |||
| as="h2" | |||
| > | |||
| { title } | |||
| <span className="editor-post-card-panel__title-name"> | |||
There was a problem hiding this comment.
I think this wrapper is unnecessary, see below comment for explanation.
| .editor-post-card-panel__description { | ||
| color: $gray-700; | ||
| } | ||
| } | ||
|
|
||
| .editor-post-card-panel__title-badge { |
| @@ -1,10 +0,0 @@ | |||
| .fields-field__page-title__badge { | |||
|
Thank you for the reviews 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Partial to #68020
Alternative to #68086
Use the new Badge component for the page markers.
Why?
To improve consistency and sustainability.
How?
Using the new component and removing redundant styles.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Recording.2024-12-18.at.17.00.55.mov