-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook: Add stories for the ContrastChecker component #68120
Storybook: Add stories for the ContrastChecker component #68120
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Hi @t-hamano, Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
This component is a bit special in that it doesn't render anything if the contrast is sufficient. This may confuse developers seeing this component for the first time.
How about setting a default value to intentionally cause insufficient contrast?
export const Default = {
args: {
backgroundColor: ...,
textColor: ...,
},
};
packages/block-editor/src/components/contrast-checker/stories/index.story.js
Outdated
Show resolved
Hide resolved
Thanks, @t-hamano for the wonderful suggestions. I have addressed all your comments. Please let me know if it tests well for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Works as expected.
Part of #67165
What?
This PR adds the Storybook stories for the ContrastChecker component in the block editor. It includes comprehensive stories demonstrating different text alignment states.
Testing Instructions
npm run storybook:dev
Screencast
Screen.Recording.2024-12-19.at.13.22.09.mov