Shadows: Always show reset button if hover is not supported #68122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
commented
Dec 19, 2024
Comment on lines
+172
to
+174
| &.edit-site-global-styles__shadow-editor__remove-button { | ||
| border: none; | ||
| } |
There was a problem hiding this comment.
I needed to increase the specificity of the style to reset the border, otherwise the border would remain below the button in the mobile layout.
t-hamano
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
added
[Type] Bug
|
Size Change: +6 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
juanfra
approved these changes
Dec 19, 2024
|
Thanks for the review!
Yes, I think we need to. For example, the reset button added by #67116 is not touchable on devices that don't support hover. The "Clear" button is available in the dropdown, but it may be better to always show the reset button, as in this PR.
|
|
Flaky tests detected in b41852a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12408743322
|
|
Thanks for the work on this 👍 LGTM! |
That was my thought. I'll adapt the other reset to get this fixed. Thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up #67705
What? Why? How?
#67705 made the reset button in the shadow panel visible only on hover. However, I found that it was not possible to remove the shadow on devices that don't support hover. Therefore, I made the reset button visible on all devices that don't support hover.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast