Storybook: Make prop sort order consistent #68152
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Developer Documentation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
approved these changes
Dec 19, 2024
| @@ -108,6 +108,9 @@ export const parameters = { | |||
| sort: 'requiredFirst', | |||
| }, | |||
| docs: { | |||
| controls: { | |||
| sort: 'requiredFirst', | |||
There was a problem hiding this comment.
Good find 👍 It's interesting that we had it "on" for stories, but not for docs.
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 002565a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12418556147
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered in #68099
What?
Ensures consistent sorting order of the props tables in Storybook docs view and story view.
Why?
The sorting order of the props table in Docs view and Story view can be different.
For example, see in
DropdownMenu:How?
There is actually a separate config for the Docs view 😳
Testing Instructions
See Storybook docs and story views for a component like DropdownMenu.