Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trailing spaces in navigation block classnames #68161

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

talldan
Copy link
Contributor

@talldan talldan commented Dec 20, 2024

What?

Fixes the very minor issue in #67999, adds some trimming to navigation block classnames

Testing Instructions

  1. View a navigation block on the frontend of a site, ensure it's one that's configured to show the Overlay Menu on mobile or always.
  2. Open dev tools and either reduce the width of the browser or use the mobile device simulation thing
  3. Inspect the navigation hamburger menu (or two buns with no burger) button
  4. Check that the wp-block-navigation__responsive-container-open class on the button has no trailing space
  5. Click the hamburger button
  6. Check that the wp-block-navigation__responsive-container doesn't have two spaces after it.

Screenshots or screencast

Before After
Screenshot 2024-12-20 at 10 01 03 am Screenshot 2024-12-20 at 10 00 40 am

@talldan talldan added [Type] Code Quality Issues or PRs that relate to code quality [Block] Navigation Affects the Navigation Block labels Dec 20, 2024
@talldan talldan self-assigned this Dec 20, 2024
Copy link

github-actions bot commented Dec 20, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: talldan <talldanwp@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Flaky tests detected in e635f63.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12424146647
📝 Reported issues:

Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before After
Screenshot 2024-12-23 at 11 52 20 am Screenshot 2024-12-23 at 11 52 55 am
Screenshot 2024-12-23 at 11 55 03 am Screenshot 2024-12-23 at 11 54 07 am

@talldan talldan merged commit 212144c into trunk Dec 23, 2024
70 checks passed
@talldan talldan deleted the fix/navigation-classname-trailing-spaces branch December 23, 2024 02:05
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants