Styles: Use justify-content: flex-start instead of start
#68199
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I wasn't planning on adding a CHANGELOG entry, but happy to add one if y'all feel it's worthy. |
|
Size Change: -38 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b6c95dc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12433433374
|
mirka
reviewed
Dec 20, 2024
There was a problem hiding this comment.
I was looking into this, and found:
startandflex-startare not the same thing.startfollows text direction and writing mode, whileflex-startfollows the main axis of a flexbox container.- Browser support is currently acceptable (MDN, Can I use).
- Our version of
autoprefixeris quite old (10.4.14, released nearly two years ago), and this warning has been removed since 10.4.19.
So regardless of whether these changes are appropriate for these three specific stylesheets, I'm wondering if the "correct" way to address this is to update our autoprefixer dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR resolves two warnings in Storybook.
Why?
Just fixing warnings.
How?
Using
justify-content: flex-startinstead ofjustify-content: start.Testing Instructions
?path=/story/components-button--icon&args=text:WordPress)?path=/story/components-tabs--vertical)Testing Instructions for Keyboard
Same
Screenshots or screencast