Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify warning message in Navigation block settings. #68218

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from
+79 −167
Open

Simplify warning message in Navigation block settings. #68218

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5e7ddff
Simplify warning message in Navigation block settings. Fixes #68181
towfeeqkhan Dec 21, 2024
3ff9b06
Fix: lint issues for packages\block-library\src\navigation\edit\index.js
towfeeqkhan Dec 21, 2024
882dcd4
Revert "git push origin fix-simplify-warning-message-#68181Fix: lint …
towfeeqkhan Dec 21, 2024
95eb013
Simplify warning message in Navigation block settings. Fixes #68181
towfeeqkhan Dec 24, 2024
2f8acff
Simplify warning message in Navigation block settings. Fix #68181
towfeeqkhan Dec 24, 2024
9085699
Simplify warning message in Navigation block settings. Fix #68181
towfeeqkhan Dec 24, 2024
403aaad
Merge branch 'fix-simplify-warning-message-#68181' of https://github.…
towfeeqkhan Dec 24, 2024
af8d0c4
edit package.json package-lock.json
towfeeqkhan Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,5 +297,8 @@
},
"workspaces": [
"packages/*"
]
],
"dependencies": {
"eslint": "8.3.0"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no changes for this PR's package.json and package-lock.json files.

Please refer to the documentation for setting up code editor extensions.

}
2 changes: 1 addition & 1 deletion packages/block-library/src/navigation/edit/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ function Navigation( {
const submenuAccessibilityNotice =
! showSubmenuIcon && ! openSubmenusOnClick
? __(
'The current menu options offer reduced accessibility for users and are not recommended. Enabling either "Open on Click" or "Show arrow" offers enhanced accessibility by allowing keyboard users to browse submenus selectively.'
'Reduced accessibility. Enable "Open on Click" or "Show arrow" for better keyboard navigation.'
)
: '';

Expand Down
Loading