DocumentTools: Use standard ToolbarButton for inserter #68332
Merged
+3
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Code Quality
mirka
commented
Dec 26, 2024
| min-width: $button-size-compact; | ||
| width: $button-size-compact; | ||
| height: $button-size-compact; | ||
| padding: 0; |
There was a problem hiding this comment.
The padding doesn't seem to be necessary?
There was a problem hiding this comment.
Not needed, yes, the button is unchanged as the styles currently come from here:
gutenberg/packages/editor/src/components/document-tools/style.scss
Lines 39 to 48 in dd77795
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -33 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in dd77795. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12508186171
|
tyxla
approved these changes
Dec 27, 2024
| min-width: $button-size-compact; | ||
| width: $button-size-compact; | ||
| height: $button-size-compact; | ||
| padding: 0; |
There was a problem hiding this comment.
Not needed, yes, the button is unchanged as the styles currently come from here:
gutenberg/packages/editor/src/components/document-tools/style.scss
Lines 39 to 48 in dd77795
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #68328
What?
Use a standard
ToolbarButtonfor the inserter button inDocumentTools.Why?
To reduce unnecessary style overrides (ToolbarButton uses the
"compact"Button size by default). This will also prevent a size deprecation warning when we start logging them in #68328.Testing Instructions
In the block editor, check the main inserter button in the top left and see that there are no visual changes.
Note that there are multiple states to check:
Screenshots or screencast
This is the inserter button in DocumentTools: