-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Remove unnecessary Tooltip
component from linked button
#68498
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Hi @afercia, |
packages/components/src/border-box-control/border-box-control-linked-button/component.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@im3dabasia thanks for working on this.
I left a note about removing an apparently unnecessary View component.
Also, a changelog entry should be added to the 'Unreleased' section of the packages/components/CHANGELOG.md
file referencing the changes in the BorderBoxControl and BoxControl components. For an example, see this entry that references two components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@im3dabasia can you please solve the merge conflict in packages/components/CHANGELOG.md
when you have a chance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes: #66271
What?
Quick code quality PR to remove unnecessary usage of the Tooltip component.
Why?
Improve on code quality
How?
Remove Tooltip component and leverage the built-in Button label prop.
Testing Instructions
border-box-control-linked button
spacing-sizes-control linked button
Screenshots
border-box-control-linked button
spacing-sizes-control linked button
box-control-linked-button (I tested in the in the boxcontrol story)