Performance: Improve StyleBook resize responsiveness for Classic Theme #68980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Performance
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I think last usage of |
|
Size Change: -10 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
@Mamaduka Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR improves resize responsiveness by removing unnecessary resize observers from the StyleBook for the Classic theme.
Closes #68978
Why?
When I measured with the browser developer tools, I confirmed that a large number of requests like the one below were generated every time the canvas was resized:
These seem to be related to dynamic blocks that are rendered on the server side.
I suspected that this was due to the
StyleBookcomponent andStyleBookPreviewcomponent using theuseResizeObserverhook, which causes re-rendering every time the canvas is resized.How?
This hook seems to be used to monitor the width of the container and add the CSS selector
is-widewhen the width is 600px or more. However, this CSS selector is not used anywhere (See this stylesheet).When I remove these resize observers, the resizing responsiveness of the canvas seems to improve dramatically.
Testing Instructions
Screenshots or screencast
Compare this to the video uploaded in #68978.
4efc8f5d107f7f1e4621238fcda537d3.mp4