GitHub Actions workflow hardening #69126
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
These changes harden the security of the GitHub Actions workflows. GitHub Actions workflows operate in a highly privileged software supply chain environment, for example they have access to publish npm packages, deploy the plugin to the WordPress.org plugin directory, and push commits to the repo. Hardening these workflows reduces the attack surface available to vulnerabilities and malicious actors.
See WordPress/wordpress-develop#8007 for where the same thing was done for the
wordpress-developrepo.permissionsdeclarations to workflows and jobs.Why?
GitHub Actions workflows are highly privileged. They can push to the repo, they can publish packages, and they work with inputs that shouldn't necessarily be trusted. Hardening the workflows reduces the attack surface for including malicious code in a package or exposing sensitive information.
Notes
wordpress-developandgutenbergrepos, which will come at a later date. The Actionlint linter will remain, as it is in thewordpress-developrepo.References
Testing Instructions
TBD