Omit edit-only behaviors from Iframe in previews
#69132
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
[Type] Bug
|
Size Change: +111 B (+0.01%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
stokesman
force-pushed
the
fix/preview-iframe-omit-unneeded-refs
branch
from
bddc748 to
ff03941
Compare
stokesman
force-pushed
the
fix/preview-iframe-omit-unneeded-refs
branch
from
ff03941 to
7d6dd86
Compare
6 tasks
|
Flaky tests detected in 7d6dd86. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13268800025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This updates the
Iframecomponent so that some behaviors are omitted when not needed such as in block/pattern previews and the "view" canvas in the Site editor. This includes a change in the edit-site package that was needed as a consequence.Why?
How?
This omits writing flow, block selection clearing and event bubbling behaviors when the content is not editable.
In lieu of describing the details here I’ll put them in review comments.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast