Data Module: Add the getEntityRecords support #6939
Conversation
| const received = ( await fulfillment.next() ).value; | ||
| expect( received ).toEqual( receiveEntityRecords( 'root', 'postType', Object.values( POST_TYPES ) ) ); | ||
| } ); | ||
| } ); |
There was a problem hiding this comment.
Would it be worthwhile to have taxonomy tests here too?
There was a problem hiding this comment.
I don't think so. I think it's worthwhile is to add tests to ensure the selectors/resolvers are generated (the code in the core-data/index.js) but several parts of this code are already tests: the methodName and the underlying selectors/resolvers.
core-data/resolvers.js
Outdated
| export async function* getTaxonomies() { | ||
| const taxonomies = await apiRequest( { path: '/wp/v2/taxonomies?context=edit' } ); | ||
| yield receiveTaxonomies( taxonomies ); | ||
| export async function* getEntityRecords( state, kind, name ) { |
There was a problem hiding this comment.
I guess I'm missing JSDoc here
| }, | ||
| ( state, kind, name ) => ( [ | ||
| state.entities[ kind ][ name ].byKey, | ||
| ] ) |
There was a problem hiding this comment.
Tab should be space before the closing parenthesis.
There was a problem hiding this comment.
Or just don't use redundant parentheses. Unless the argument is they add clarity to disambiguate between [ and { (but then, what about implicit returns?).
| @@ -5,7 +5,8 @@ import { find, upperFirst, camelCase } from 'lodash'; | |||
|
|
|||
| const entities = [ | |||
| { name: 'postType', kind: 'root', key: 'slug', baseUrl: '/wp/v2/types' }, | |||
| { name: 'media', kind: 'root', baseUrl: '/wp/v2/media' }, | |||
| { name: 'media', plural: 'mediaItems', kind: 'root', baseUrl: '/wp/v2/media' }, | |||
| { name: 'taxonomy', kind: 'root', key: 'slug', baseUrl: '/wp/v2/taxonomies', plural: 'taxonomies' }, | |||
There was a problem hiding this comment.
Nit: Inconsistent property ordering.
- Previous line:
name,plural,kind,baseUrl - This line:
name,kind,key,baseUrl,plural
| const nameSuffix = upperFirst( camelCase( name ) ); | ||
| return `get${ kindPrefix }${ nameSuffix }`; | ||
| const nameSuffix = upperFirst( camelCase( name ) ) + ( usePlural ? 's' : '' ); | ||
| const suffix = usePlural && entity.plural ? upperFirst( camelCase( entity.plural ) ) : nameSuffix; |
There was a problem hiding this comment.
The previous line is wasted work if usePlural && entity.plural is truthy. Further, should this be extracted to a utility? Or refactored to logic where we consider a custom plural value before doing the 's' concatenation.
Aside: On the fence about whether taking on this responsibility from the developer via some utility like pluralize could be a good thing.
There was a problem hiding this comment.
I know but I wanted to avoid the embedded ifs or ternaries.
closes #6780
This PR adds support to the
getEntityRecordsselectors/resolvers to the core data module to avoid duplication across the different entities.Testing instructions