-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newly created paragraph block is not showing the font size. #7240
Newly created paragraph block is not showing the font size. #7240
Conversation
…ze is not set for components-range-control__number element. This commit fixes the issue.
error Unnecessary 'else' after 'return' no-else-return
As I understand it, this may have been an intentional choice to not have an explicit size assigned for the paragraph, but rather to inherit the size which would otherwise apply by default there, since 16px may not be the default depending upon the theme. |
I don't think this is expected to enforce the default size for all Paragraph blocks. As far as I remember from discussions with @jorgefilipecosta, it is possible to provide a different size using CSS, and we are able to detect it and set proper value, i.e. if a theme author changes the default font size to 17px, it will be set as a default value, but it won't force the block to append a class name or style which would duplicate the information. @jorgefilipecosta, can you confirm? |
The "number field" of size is blank to indicate to the user that no choice regarding the font-size was made. We may improve this if we find a UI that allows the user to know the default font-size value e.g: 16 px but also shows that this value was not set it is just a default in that scenario and may change (something identical to a placeholder in a text field). |
Based on previous comments, closing this pull request as invalid. Thanks for the contribution and for prompting the discussion! |
Newly added paragraph block is not showing the font size.
The font size is not set for components-range-control__number element. This commit fixes the issue.