Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Archives block #7949

Merged
merged 11 commits into from
Jul 16, 2018
Merged

Add Archives block #7949

merged 11 commits into from
Jul 16, 2018

Commits on Jul 16, 2018

  1. Changes from PR #5495 squashed into single commit 

    Co-authored-by: Pascal Birchler <hello@pascalbirchler.ch>
Co-authored-by: Miina Sikk <miina.sikk@gmail.com>
Co-authored-by: Weston Ruter <weston@xwp.co>
    @talldan @swissspidy
    @miina @westonruter
    4 people committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    07da41e View commit details
    Browse the repository at this point in the history

  2. Remove archived keywords, since the title is implicitly a keyword alr… 

    …eady
    @talldan
    talldan committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    a15f0e0 View commit details
    Browse the repository at this point in the history

  3. Use already destructured property attributes over `this.props.attri… 

    …butes`
    @talldan
    talldan committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    eca4224 View commit details
    Browse the repository at this point in the history

  4. Use title case for copy

    @talldan
    talldan committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    3677a65 View commit details
    Browse the repository at this point in the history

  5. Use Disabled element to prevent interaction with Archives Block edi… 

    …tor view

Use of `pointer-events` to disable interaction was problematic. It
didn't disabled the dropdown version of the block and it doesn't prevent
keyboard interaction.

The Disabled component handles these situations.
    @talldan
    talldan committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    480338c View commit details
    Browse the repository at this point in the history

  6. Rename block.js to edit.js for consistency with other blocks

    @talldan
    talldan committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    c785d48 View commit details
    Browse the repository at this point in the history

  7. Convert ArchivesEdit to a function component

    @talldan
    talldan committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    ad5aa1d View commit details
    Browse the repository at this point in the history

  8. Remove isSelected boolean and inline InspectorControls

    @talldan
    talldan committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    0696d4c View commit details
    Browse the repository at this point in the history

  9. Render archives list container as ul when a list and div when a d… 

    …ropdown
    @talldan
    talldan committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    65025c1 View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary React keys

    @mcsf
    mcsf committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    3c964d3 View commit details
    Browse the repository at this point in the history

  11. Improve description copy

    @mcsf
    mcsf committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    5c3ba36 View commit details
    Browse the repository at this point in the history