Respect Posts Page #8259
Merged
Respect Posts Page #8259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ordPress (as per similar functionality from edit-form-advanced.php).
aduth
requested changes
Jul 30, 2018
aduth
requested changes
Jul 30, 2018
lib/register.php
Outdated
| @@ -269,6 +269,10 @@ function gutenberg_can_edit_post( $post ) { | |||
| return false; | |||
| } | |||
|
|
|||
| if ( $post->ID == get_option( 'page_for_posts' ) && empty( $post->post_content ) ) { | |||
There was a problem hiding this comment.
- Needs Yoda condition (see failing build)
- Should ideally be using strict equality. This isn't codified in the standard, but if we expect it to take a particular value shape, we'd be better off than to allow leniency (prone to false positives)
- The condition is not self-explanatory, and could do for an inline code comment explaining why it exists.
aduth
added
the
Backwards Compatibility
… `page_for_posts` option as an integer. Added an inline comment.
…n the posts page has content and false when the posts page has no content.
aduth
reviewed
Jul 31, 2018
| 'post_title' => 'Blog', | ||
| 'post_content' => '', | ||
| ) ); | ||
| update_option( 'page_for_posts', $blog_page_without_content ); |
There was a problem hiding this comment.
Are these tests isolated from one another? Is this something which should be reverted in a tearDown ?
There was a problem hiding this comment.
@aduth All MySQL queries in WordPress unit tests use the COMMIT and ROLLBACK approach to ensure that things like update_option are automatically rolled back. See https://github.com/WordPress/wordpress-develop/blob/master/tests/phpunit/includes/testcase.php#L155
aduth
approved these changes
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure that Gutenberg is disabled when on the assigned blog page in WordPress. Provides feature parity as per functionality from https://github.com/WordPress/WordPress/blob/master/wp-admin/edit-form-advanced.php#L73).
Fixes #3659
How has this been tested?
Tested manually as follows:
Added unit tests to ensure the gutenberg_can_edit_post() function returns false when attempting to edit the posts page if it does not have content and returns true when it does have content.
Screenshots
Types of changes
Bug fix - adds a check to the
gutenberg_can_edit_post()function and returns false if it is the posts page and has no content.Checklist: