Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish the switch control. #831

Merged
merged 1 commit into from
May 18, 2017
Merged

Polish the switch control. #831

merged 1 commit into from
May 18, 2017

Conversation

jasmussen
Copy link
Contributor

This PR simply tunes up the styles of the switch toggle. It adjusts the size a bit, and extracts width and height into variables, and adjusts the hover colors.

This PR simply tunes up the styles of the switch toggle. It adjusts the size a bit, and extracts width and height into variables, and adjusts the hover colors.
@jasmussen jasmussen requested a review from youknowriad May 18, 2017 09:39
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

Colours are good, and the use of variables great. I personally prefer the small size though :) but it's good too as is.

@jasmussen
Copy link
Contributor Author

I expect we'll revisit this at some point regardless. But bigger is always better when it comes to clickable ;)

Thanks Riad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants