Expand drop zone to fill the entire block #8722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earnjam
reviewed
Aug 10, 2018
| @@ -8,14 +8,12 @@ | |||
| } | |||
|
|
|||
| &.is-close-to-bottom { | |||
| background: none; | |||
There was a problem hiding this comment.
If we remove this, then it will bring back #6035, where blocks change color when dragging another block over them.
| border-bottom: 3px solid theme(primary); | ||
| } | ||
|
|
||
| &.is-close-to-top, | ||
| &.is-appender.is-close-to-top, | ||
| &.is-appender.is-close-to-bottom { | ||
| background: none; |
There was a problem hiding this comment.
Same issue here as line 11
This reverts commit cb5ffd5.
|
Hey, I've just reverted one of the commits, hope this helps 👍 |
|
Thanks @michaelsmyth94. I like the looks of this, but want to get some design feedback as well and also make sure I'm not missing anything that might break by expanding the drop zone like this. Looks like based on the history it's been set this size for a while. . |
earnjam
changed the title
|
I'm going to close this, as it's no longer really applicable after #9071 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How has this been tested?
This has been tested by dropping an image into a paragraph block.
The testing environment was the docker container included with this repository.
Tested dropping an image onto the other block types and all worked okay.
Screenshots
Before:
https://imgur.com/Kf1h664
After:
https://imgur.com/XBbBOuD
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: