Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show inline boundaries on focus #881

Merged
merged 1 commit into from
May 24, 2017
Merged

Conversation

ellatrix
Copy link
Member

No description provided.

@ellatrix ellatrix requested a review from jasmussen May 24, 2017 10:03
@jasmussen
Copy link
Contributor

Testing this, I see no difference in behavior of the inline boundaries. Which I assume is good! So if this is the intended behavior, the change looks tiny so 🚢

@ellatrix
Copy link
Member Author

@jasmussen Could you test the following in both master and this branch?

Put the cursor in a link, then put it in a different Editable or block.

In master the boundary should still be visible. In this branch it should disappear.

Is this correct?

@jasmussen
Copy link
Contributor

This is what I see in the branch:

branch

This is what I see in master:

master

Can't really tell the difference tbh.

@ellatrix
Copy link
Member Author

Can't really tell the difference tbh.

So in the top GIF, the link background shows up, then disappears after you put the caret in a different block. In the bottom GIF is stays. The top is the behaviour we want right? Can you see the difference now?

@jasmussen
Copy link
Contributor

Ah right! Solid! Ship it!

@ellatrix ellatrix merged commit a3ead0a into master May 24, 2017
@ellatrix ellatrix deleted the fix/inline-boundaries-blur branch May 24, 2017 10:59
@aduth
Copy link
Member

aduth commented May 24, 2017

Nice easy fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants