Fix: Contrast checker: Consider fontSize large when size >= 24px instead of >= 18px #9268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
force-pushed
the
fix/contrast-checker-font-size-rule
branch
from
d5021a2
to
94772e2
Compare
daniloercoli
added a commit
that referenced
this pull request
Nov 8, 2018
…rnmobile/fix-merge-content-not-refreshed-UI * 'master' of https://github.com/WordPress/gutenberg: Add missing tests for Format API code (#11562) chore: Improve undo/redo no-op (#11428) Fix: Contrast checker: Consider fontSize large when size >= 24px instead of >= 18px (#9268)
mtias
added
the
[Focus] Accessibility (a11y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8614
Thank you @afercia for catching this issue.
The rule specifies that if the text is greater or equal to 18pt it is considered large but we are using pixels so in this case the accepted practice is to consider 1pt = 1.333px and a value of 24px should be used.
How has this been tested?
I created a paragraph with background color equal to #C44B4B and text color equal to #000000. I verified that if the font size is set 23 a contrast warning is shown and if the font size is equal to 24 the warning is not shown.