Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds basic IconButton component tests. #932

Merged
merged 2 commits into from
May 30, 2017

Conversation

BE-Webdesign
Copy link
Contributor

Adds basic IconButton component tests. Related to progress on #641.

Testing Instructions
Run npm i && npm run test-unit ensure tests pass. Change Dashicon logic
to ensure tests fail as they should.

@BE-Webdesign BE-Webdesign added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label May 29, 2017
expect( iconButton.prop( 'aria-label' ) ).to.equal( 'WordPress' );
} );

it( 'with additonal className', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here and below: addditonaladditional

Copy link
Member

@nylen nylen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I think we should just merge these, it's great to have the tests and we can always add more later.

@youknowriad
Copy link
Contributor

Really great work on all these tests @BE-Webdesign 👍

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Adds basic IconButton component tests. Related to progress on #641.

Testing Instructions
Run npm i && npm run test-unit ensure tests pass. Change Dashicon logic
to ensure tests fail as they should.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@BE-Webdesign BE-Webdesign force-pushed the add/test/components/icon-button branch from 6c8f546 to 3ff6c5b Compare May 30, 2017 15:40
@BE-Webdesign BE-Webdesign merged commit 1fe4e3e into master May 30, 2017
@BE-Webdesign BE-Webdesign deleted the add/test/components/icon-button branch June 1, 2017 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants