Update from backtick quote to single quote #9332
Conversation
| @@ -101,7 +101,7 @@ const blockShortcuts = { | |||
| }, | |||
| { | |||
| keyCombination: '/', | |||
| description: __( `Change the block type after adding a new paragraph.` ), | |||
| description: __( 'Change the block type after adding a new paragraph.' ), | |||
There was a problem hiding this comment.
I'd say that's probably the cause of the translation issue and we might want to fix it in the babel plugin cc @aduth
But I agree that there's no real reason to use backticks here.
There was a problem hiding this comment.
Considering that the template strings are targeted specifically at variable interpolation, something we explicitly cannot support in the i18n string extraction, it's not entirely surprising to me that I'd not have included support for them in the original implementation.
Usage like this seems valid to parse, but also as pointed out, the template string is not necessary here. Easy to overlook though. Maybe the other option is to add a lint rule to forbid template strings as argument to __ ?
There was a problem hiding this comment.
Makes sense if the eslint rule is easy to add, I'm all for it 👍
Description
The string "Change the block type after adding a new paragraph" doesn't show for translate and the only diference is the backtick quote use instead of single quote. But I don't know if that is the real cause. Anyway for codding standards I changed to single quote.
Types of changes
Bug fix.