-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix focus rectangle regression #942
Conversation
Also custom style the focus for editable toolbars.
We are likely going to need to tweak these further as we go, but for now going with the mockups.
What are testing instructions? |
@joen Looks great. I'm getting two rectangles for toolbar buttons: |
Ack sorry missed the two comments here. Testing instructions are tabbing through buttons, and verifying there's a focus rectangle. I'm going to have to remove the one on toolbar buttons, that's a regression, and I'm going to darken the outline a little bit also. |
I've updated this PR and now it should be good to review:
|
@jasmussen I'm still seeing two lines. Is this intended? |
Argh, can't believe this took so long. Should finally be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
This PR fixes a focus rectangle regression I introduced in a previous commit. In doing so, it's also starting work on #904. More work will need to be done, I suspect, and designs tuned, but this PR improves things.