-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome: Adding a confirm utility to replace window.confirm
calls
#960
Conversation
4fa584d
to
7242d03
Compare
window.confirm
calls
Pushed a little polish. I think we might want to do more polish, but this is great for now! |
Out of curiosity: Why do we want this? |
I don't know, It just seems a better UI to me :). I expect us to need this later for deletions and stuff like that? |
Maybe not as pretty 😛 But also consistent / expected. Can't always use the styled dialog anyways, e.g. |
Great question to be asking! I'm actually fine with using the stock |
Yep |
I think the styled version looks decent, but since we have no urgent need for it, and it's conceivable it could come with various accessibility issues we'd want to address, perhaps we should go with window.confirm for now, and then revisit this PR if and when it becomes necessary. |
Ok Closing for now :) |
Testing instructions
Try to toggle the "private" visibility to see the dialog.