-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to skip PublishSidebar on publishing #9760
Merged
Merged
Commits on Sep 17, 2018
-
Configuration menu - View commit details
-
Copy full SHA for b7cc241 - Browse repository at this point
Copy the full SHA b7cc241View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3f0c24 - Browse repository at this point
Copy the full SHA e3f0c24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85edadc - Browse repository at this point
Copy the full SHA 85edadcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0488595 - Browse repository at this point
Copy the full SHA 0488595View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14ea423 - Browse repository at this point
Copy the full SHA 14ea423View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4c237e - Browse repository at this point
Copy the full SHA f4c237eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a00c13 - Browse repository at this point
Copy the full SHA 1a00c13View commit details -
Configuration menu - View commit details
-
Copy full SHA for c659529 - Browse repository at this point
Copy the full SHA c659529View commit details -
Move publish sidebar logic to core/editor store
This logic is used by the PostPublishPanel, which lives in editor. We don't want editor to depend on anything from edit-post. An alternative approach could be to keep the logic in edit-post and use the the PrePublish and PostPublish extensions. In my view, those are meant for allowing plugins to inject their own panels into the PublishPanel. Dismissing the panel is a core action and using the extensions to circumvent the editor/edit-post separation would be a convoluted way to add support for dismissing the panel.
Configuration menu - View commit details
-
Copy full SHA for e888220 - Browse repository at this point
Copy the full SHA e888220View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3e9fa8 - Browse repository at this point
Copy the full SHA b3e9fa8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f78a332 - Browse repository at this point
Copy the full SHA f78a332View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e2877f - Browse repository at this point
Copy the full SHA 3e2877fView commit details -
Configuration menu - View commit details
-
Copy full SHA for dbd6090 - Browse repository at this point
Copy the full SHA dbd6090View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea5dc6a - Browse repository at this point
Copy the full SHA ea5dc6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for afae18d - Browse repository at this point
Copy the full SHA afae18dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f45e20 - Browse repository at this point
Copy the full SHA 2f45e20View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bfc2a5 - Browse repository at this point
Copy the full SHA 7bfc2a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c65ea7c - Browse repository at this point
Copy the full SHA c65ea7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 18036e2 - Browse repository at this point
Copy the full SHA 18036e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c37b6a8 - Browse repository at this point
Copy the full SHA c37b6a8View commit details -
These data has been moved to edit-post store as per #4661
Configuration menu - View commit details
-
Copy full SHA for d1c69c5 - Browse repository at this point
Copy the full SHA d1c69c5View commit details -
In theory, isPublishSidebarEnabled shouldn't be ever undefined in the preferences object, so this shouldn't be necessary. In practice, we use a localStorage mechanism to persist parts of the state in between sessions (like whether the user has already seen the tips or not). For the core/editor store we persist the preferences key, which contains an object. This is the problem: the localStorage mechanism doesn't check whether the cached preferences object and the state preferences object have the same shape, it just overwrites the current state, so new added keys are deleted. While this bug is not fixed and deployed, we want this preventive measure in place.
Configuration menu - View commit details
-
Copy full SHA for 1be0b54 - Browse repository at this point
Copy the full SHA 1be0b54View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79ced01 - Browse repository at this point
Copy the full SHA 79ced01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78ebeec - Browse repository at this point
Copy the full SHA 78ebeecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 87b372d - Browse repository at this point
Copy the full SHA 87b372dView commit details
Commits on Sep 18, 2018
-
Configuration menu - View commit details
-
Copy full SHA for acffe70 - Browse repository at this point
Copy the full SHA acffe70View commit details
Commits on Sep 19, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 37900cc - Browse repository at this point
Copy the full SHA 37900ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6637b7e - Browse repository at this point
Copy the full SHA 6637b7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d7c7151 - Browse repository at this point
Copy the full SHA d7c7151View commit details -
Configuration menu - View commit details
-
Copy full SHA for b50ca1d - Browse repository at this point
Copy the full SHA b50ca1dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.