Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to skip PublishSidebar on publishing #9760

Merged
merged 30 commits into from
Sep 19, 2018

Commits on Sep 17, 2018

  1. Configuration menu
    Copy the full SHA
    b7cc241 View commit details
    Browse the repository at this point in the history
  2. Add data API

    oandregal committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    e3f0c24 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    85edadc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0488595 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    14ea423 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f4c237e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1a00c13 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c659529 View commit details
    Browse the repository at this point in the history
  9. Move publish sidebar logic to core/editor store

    This logic is used by the PostPublishPanel, which lives in editor.
    We don't want editor to depend on anything from edit-post.
    
    An alternative approach could be to keep the logic in edit-post
    and use the the PrePublish and PostPublish extensions.
    In my view, those are meant for allowing plugins to inject their
    own panels into the PublishPanel. Dismissing the panel is a core
    action and using the extensions to circumvent the editor/edit-post
    separation would be a convoluted way to add support for dismissing the panel.
    oandregal committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    e888220 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b3e9fa8 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    f78a332 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    3e2877f View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    dbd6090 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    ea5dc6a View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    afae18d View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    2f45e20 View commit details
    Browse the repository at this point in the history
  17. Align to bottom

    oandregal committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    7bfc2a5 View commit details
    Browse the repository at this point in the history
  18. Update wording

    oandregal committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    c65ea7c View commit details
    Browse the repository at this point in the history
  19. Update copy

    oandregal committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    18036e2 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    c37b6a8 View commit details
    Browse the repository at this point in the history
  21. Remove outdated docs

    These data has been moved to edit-post store as per
    #4661
    oandregal committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    d1c69c5 View commit details
    Browse the repository at this point in the history
  22. Preventive measure

    In theory, isPublishSidebarEnabled shouldn't be ever undefined
    in the preferences object, so this shouldn't be necessary.
    
    In practice, we use a localStorage mechanism to persist
    parts of the state in between sessions (like whether the user
    has already seen the tips or not). For the core/editor store
    we persist the preferences key, which contains an object.
    This is the problem: the localStorage mechanism doesn't check
    whether the cached preferences object and the state preferences object
    have the same shape, it just overwrites the current state,
    so new added keys are deleted.
    
    While this bug is not fixed and deployed,
    we want this preventive measure in place.
    oandregal committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    1be0b54 View commit details
    Browse the repository at this point in the history
  23. Fix and add tests

    oandregal committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    79ced01 View commit details
    Browse the repository at this point in the history
  24. Add e2e test

    oandregal committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    78ebeec View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    87b372d View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2018

  1. chore: Tweak styles

    tofumatt authored Sep 18, 2018
    Configuration menu
    Copy the full SHA
    acffe70 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2018

  1. Configuration menu
    Copy the full SHA
    37900cc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6637b7e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d7c7151 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b50ca1d View commit details
    Browse the repository at this point in the history