Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Pin fetch polyfill to 3.0 UMD distributable #9795

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

aduth
Copy link
Member

@aduth aduth commented Sep 11, 2018

This should be included in a 3.8 final release.

This pull request seeks to resolve an issue where the fetch polyfill is no longer usable in Internet Explorer 11. This was due to the fact that we had never pinned the version of polyfill we consume, thus when its latest 3.0.0 release included breaking changes to the default build targetting JavaScript modules, not supportable in IE11.

The changes here target the IE-compatible UMD build, and also pin to the 3.0.0 version to avoid future issues.

Testing instructions:

Verify that saving works as expected in Internet Explorer and your preferred browser.

Based on our hashing of vendor scripts, I do not expect that an existing downloaded/cached copy should need to be deleted.

@aduth aduth added [Type] Bug An existing feature does not function as intended [Priority] High Used to indicate top priority items that need quick attention Framework Issues related to broader framework topics, especially as it relates to javascript Browser Issues Issues or PRs that are related to browser specific problems labels Sep 11, 2018
@aduth aduth added this to the 3.8 milestone Sep 11, 2018
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems Framework Issues related to broader framework topics, especially as it relates to javascript [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants