Latest Comments block: minor code cleanup #9832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR needs a rebase, but #10635 modifies one of the same files as this PR, so I'll wait until that is merged first. Could this be milestoned for 4.1? |
earnjam
added
[Type] Code Quality
This was referenced Nov 2, 2018
Closed
|
Closing in favor of #11411. |
ZebulanStanphill
deleted the
update/latest-comments-minor-code-cleanup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reorders the attributes in the Latest Comments block's
index.phpalphabetically and removes an unnecessary''item from theenumarray of thealignobject that has no effect on what classes get applied and what alignments are considered valid.Notably, the values in
enumactually do have an effect on what alignments are considered valid. There is no documentation for this, as far as I can tell, and no way to use this sameenumarray in JavaScript.How to test
Try setting alignments on the Latest Comments block. Ensure that the correct classes (or lack thereof) are applied in both the editor and the front-end. If you notice an issue, compare to
masteras it may be a bug there as well.