Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add simplified block grammar spec to handbook #9837

Merged
merged 1 commit into from
Sep 13, 2018

Conversation

mcsf
Copy link
Contributor

@mcsf mcsf commented Sep 12, 2018

Description

Add docs/grammar.md, a document auto-generated since #6116 containing a simplified specification of the Gutenberg block grammar, to the Gutenberg Handbook.

How has this been tested?

Changes to the handbook aren't very testable beforehand. Once these changes are merged and applies, the expectation is that:

Types of changes

Documentation.

@mcsf mcsf added [Type] Developer Documentation Documentation for developers [Feature] Parsing Related to efforts to improving the parsing of a string of data and converting it into a different f labels Sep 12, 2018
@mcsf mcsf added this to the 3.9 milestone Sep 12, 2018
@mcsf mcsf requested review from pento and mtias September 12, 2018 16:42
Copy link
Member

@pento pento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📖

@pento pento merged commit 1c68241 into master Sep 13, 2018
@pento pento deleted the add/docs-manifest-block-grammar branch September 13, 2018 06:56
@pento
Copy link
Member

pento commented Sep 13, 2018

I had to make a couple of tweaks to the docs importer: https://meta.trac.wordpress.org/changeset/7668

@mcsf
Copy link
Contributor Author

mcsf commented Sep 13, 2018

I had to make a couple of tweaks to the docs importer

Thanks!

@aduth
Copy link
Member

aduth commented Sep 14, 2018

When I run npm run docs:build, it removes the "grammar" entry from manifest.json.

@mcsf
Copy link
Contributor Author

mcsf commented Sep 18, 2018

When I run npm run docs:build, it removes the "grammar" entry from manifest.json.

Oh, because I'm an idiot who hadn't realized root-manifest.json is the cool kids' place now. Fix in #10014.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Parsing Related to efforts to improving the parsing of a string of data and converting it into a different f [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants