-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Prepublish text for scheduled posts #9986
Fix: Prepublish text for scheduled posts #9986
Conversation
You could just change "publish" to "schedule" in the original message and it would be accurate, no? |
+1 for this change overall, but "ready to schedule" feels a bit awkward. We may want to reconsider this in a larger context. This text currently shows one of three variants: "(Are you) ready to publish?" One option would be to nix the differentiation altogether, and opt for something generic, like "Are you ready?" or "Ready to go?", or even just "Pre-publish check" to reinforce the language we're using for this panel and its associated setting. Another option might be to nix the question bit altogether, so the title becomes an instruction: "Publish", "Schedule", "Submit for review". It's a bit simpler and clearer this way, and avoids some of the awkwardness that pops up in the latter two instances. See also minor copy changes here to be introduced in #9398 ("Are you ready to publish?" -> "Ready to publish?") |
FWIW, I'd vote for something that keeps the differentiation, because I think the specificity in the headline helps create confidence in the user that they're doing the thing the intended to do. (I also don't find "ready to schedule" terribly awkward, but that's just me.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good from the code point of view 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me!
Let's go ahead and merge this in then, and we can iterate as/if needed in #9398. I could be overthinking things. 🧐 |
Description
Fixes #9960.
When scheduling a new post, the text displayed in the prepublish panel was a little misleading to the user:
This fix adds a more appropriate message:
How has this been tested?
I created a new post, scheduled it at a later date and clicked the 'Schedule' button: the above message appears.
Types of changes
It introduces two variables
prePublishTitle
andprePublishBodyText
which get assigned depending on the publish date or if the user is a contributor.