Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom classNames for dynamic blocks #9995

Merged
merged 1 commit into from
Sep 18, 2018
Merged

Fix custom classNames for dynamic blocks #9995

merged 1 commit into from
Sep 18, 2018

Conversation

youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Sep 18, 2018 •
edited
Loading

closes #9991 and closes #9929

This PR fixes a small regression where custom classes for dynamic blocks were not parsed properly after a save.

This was a conflict with a behavior considering removal of custom classes from markup as a valid operation even if the block comment includes a custom className. But blocks returning null don't have a wrapper to which the custom className is added which means we shouldn't remove the className property in that case.

Testing instructions

@youknowriad youknowriad added the [Type] Bug An existing feature does not function as intended label Sep 18, 2018
@youknowriad youknowriad added this to the 4.0 milestone Sep 18, 2018
@youknowriad youknowriad self-assigned this Sep 18, 2018
@youknowriad youknowriad requested review from johngodley, aduth and a team September 18, 2018 09:48
johngodley
johngodley approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@johngodley johngodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that it fixes the problem and doesn't affect the previous custom class change 👍

@youknowriad youknowriad merged commit 7c7e764 into master Sep 18, 2018
@youknowriad youknowriad deleted the fix/custom-class-dynamic-blocks branch September 18, 2018 12:57
@Soean Soean mentioned this pull request Oct 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngodley johngodley johngodley approved these changes

@aduth aduth Awaiting requested review from aduth

Assignees

@youknowriad youknowriad

Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Custom css classes for dynamic blocks are not saved className saved but not loaded on F5 (reload)
2 participants
@youknowriad @johngodley