Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[Bug] Remove button styling from "no results" text #215

Closed
zackkrida opened this issue Sep 15, 2021 · 4 comments · Fixed by #272
Closed

[Bug] Remove button styling from "no results" text #215

zackkrida opened this issue Sep 15, 2021 · 4 comments · Fixed by #272
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed

Comments

@zackkrida
Copy link
Member

Description

When there are no image or audio results available, the "No more images" text is styled as a button and includes a :( frowning emoticon. We should replace this with a plain style that doesn't suggest interactivity like a button does. We should also replace the copy.

Solution

When reaching the end of a set of search results, show nothing:

before

CleanShot 2021-09-15 at 14 41 04@2x

after

CleanShot 2021-09-15 at 14 41 33@2x

When a search term has zero results, remove the error message and "no more images" button, and instead modify the "Not finding what you're looking for?" text to read "No {media} results for {search term}", like so:

before

CleanShot 2021-09-15 at 14 43 23@2x

after

CleanShot 2021-09-15 at 14 46 39@2x
@zackkrida zackkrida added good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software labels Sep 15, 2021
@zackkrida zackkrida changed the title [Bug] Remove button styling from [Bug] Remove button styling from "no results" text Sep 15, 2021
@Kevan-Y
Copy link
Contributor

Kevan-Y commented Sep 28, 2021

Hi, I'm a newbie here. I don't have that must knowledge in Vue.js. But it's a little bit similar to React.js framework.
I would like to try this issue. Can I work on it?

@zackkrida
Copy link
Member Author

Sure @Kevan-Y you can try!

@Kevan-Y Kevan-Y mentioned this issue Sep 28, 2021
Merged
7 tasks
@Kevan-Y
Copy link
Contributor

Kevan-Y commented Sep 29, 2021

@zackkrida I’m doing this as part of Hacktoberfest and open sources class and wondered if you’d mind adding the label Hacktoberfest

@zackkrida
Copy link
Member Author

The repository has the hacktoberfest topic so it will count!

krysal pushed a commit that referenced this issue Sep 30, 2021
@Kevan-Y
Remove button styling from "no results" text (#272)
d52a388 
Remove button styling from "no results" text

Fixes #215.
Co-authored-by: Krystle Salazar <krystle.salazar@ciens.ucv.ve>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove button styling from "no results" text Kevan-Y/openverse-frontend
2 participants
@zackkrida @Kevan-Y