Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python code to use Python 3.11 #1852

Merged
merged 4 commits into from
Apr 21, 2023
Merged

Update Python code to use Python 3.11 #1852

merged 4 commits into from
Apr 21, 2023

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Apr 20, 2023

Fixes

Related to #663
Related to #1370

Description

This PR updates all packages except the catalog to use Python 3.11. The catalog is being held back by Airflow, which does not support 3.11 yet.

Testing Instructions

CI should pass.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added 🟩 priority: low Low priority and doesn't need to be rushed ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🧱 stack: api Related to the Django API 🧱 stack: ingestion server Related to the ingestion/data refresh server 🧱 stack: mgmt Related to repo management and automations labels Apr 20, 2023
@dhruvkb dhruvkb requested review from a team as code owners April 20, 2023 13:16
@dhruvkb dhruvkb requested review from krysal and obulat April 20, 2023 13:16
@github-actions github-actions bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Apr 20, 2023
@github-actions
Copy link

Full-stack documentation: https://docs.openverse.org/_preview/1852

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good! I assume this will need to be rebased after #1225 is merged.

@dhruvkb
Copy link
Member Author

dhruvkb commented Apr 21, 2023

@krysal rebased. The Dockerfiles for the API and ingestion server become unchanged after updating because the ones on main can automatically use the new version from the Pipfiles.

@obulat obulat removed the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Apr 21, 2023
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM.

.github/workflows/label_pr.yml Show resolved Hide resolved
.github/workflows/label_pr.yml Show resolved Hide resolved
documentation/Pipfile Show resolved Hide resolved
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dhruvkb dhruvkb merged commit 8a9db25 into main Apr 21, 2023
@dhruvkb dhruvkb deleted the python_311 branch April 21, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: api Related to the Django API 🧱 stack: ingestion server Related to the ingestion/data refresh server 🧱 stack: mgmt Related to repo management and automations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants