Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create "My Submitted Patterns" page #16

Closed
MichaelArestad opened this issue Nov 9, 2020 · 12 comments
Closed

Create "My Submitted Patterns" page #16

MichaelArestad opened this issue Nov 9, 2020 · 12 comments
Assignees
Labels
[Component] Theme The frontend of the pattern directory, pattern lists UI [Type] Tracking Issue

Comments

@MichaelArestad
Copy link

There should a page a user can see their submitted patterns and the status of those patterns.

  • What are the various statuses of the patterns (submitted, reviewed, rejected)?
  • How should a user get to this page? Is there something similar for plugins?
@iandunn
Copy link
Member

iandunn commented Nov 10, 2020

rejected

The Community Team uses declined as a softer word in those situations, and I think it's worked well there.

@iandunn
Copy link
Member

iandunn commented Nov 10, 2020

Is there something similar for plugins?

The Add Your Plugin page will show everyone how many are in the review queue, but I think the accepted/rejected notes are sent via email.

Is that right, @Ipstenu ?

@iandunn
Copy link
Member

iandunn commented Nov 10, 2020

How should a user get to this page?

I think the only way to see all of your plugins is on profiles.w.org. I think it'd be good to add patterns there, for consistency.

I don't think that's easy to find, though. I like how the 5ftF design has a My Pledges link in the navbar. That could link to the patterns on the profile, so we don't have to create duplicate pages.

@Ipstenu
Copy link

Ipstenu commented Nov 11, 2020

Rejections are kinda saved -- everyone who has a rejected plugin, has it listed on the 'author' card:

Screen Shot 2020-11-11 at  11 Nov - 12 12 11 PM

And everyone gets an email (except for 'it's been 6 months...'). As you can see, we don't track 'why' something was rejected. Most of the time we use it for "We've rejected Bob for the same plugin 3 times. Check the emails and see if he's just not getting something or if we have a bigger issue."

In general, rejections are:

  • Submitter took 6 months and never finished the review
  • Plugin is not acceptable
  • Specific issue with submitter

@tellyworth
Copy link

@MichaelArestad raised the interesting idea that people might like to use this as a repository for their own patterns. For example a designer or integrator might keep a library of patterns for easy access on their client sites.

We won't have any way to authenticate users from an external editor, which means they can't be completely private. But I wonder if this hints at a more nuanced set of statuses than for the plugin/theme directories. Something like:

  • I create/remix a pattern and save it.
  • It's now accessible to me (as author) on the front end of the directory, but not visible there to others or logged-out users.
  • From the Gutenberg editor on my site, I can search for my pattern with some kind of explicit prefix, like "user:tellyworth green button"
  • If I want to publish it to the world, I can go back to the directory and "submit".
  • If it's reviewed and accepted, it becomes visible on the directory front end and searchable from the pattern tab in the editor as "green button".
  • If it's declined or still pending review it stays in the "private" state.

That suggests something slightly more complex than 3 status values.

@MichaelArestad
Copy link
Author

@tellyworth Exactly. I don't think we need to start with that feature as a priority, but down the road, it could be a nice enhancement.

@ryelle ryelle added the [Component] Pattern Directory The backend of the pattern directory: submission, management, etc label Nov 12, 2020
@ryelle ryelle added the [Component] Theme The frontend of the pattern directory, pattern lists UI label Jan 19, 2021
@ryelle ryelle changed the title Submitted Patterns page Create "My Submitted Patterns" page Jan 19, 2021
@carolinan
Copy link

carolinan commented Feb 28, 2021

Please consider allowing contributors to remove and transfer their patterns as well.
I don't know how the plugin team handles it but for themes this process is manual.

@ryelle
Copy link
Contributor

ryelle commented Mar 30, 2021

Design for "My Patterns"

Pending Review
Successfuly Published

There's also more information, including an edit button, in the header of owned pattern details. The note about transferring ownership & removal is a good point, @shaunandrews where do you think that could fit in?

Pattern Detail - Owned - Pending

@shaunandrews
Copy link
Collaborator

Instead of a single "Edit" button, perhaps we show a menu with multiple options including transferring ownership and deleting:

image

We can also expose this menu in the grid view of patterns:

image

@ryelle ryelle added [Type] Tracking Issue and removed [Component] Pattern Directory The backend of the pattern directory: submission, management, etc labels May 7, 2021
@ryelle
Copy link
Contributor

ryelle commented May 10, 2021

To do here (create individual issues before tackling):

  • Create the My Patterns page
  • Update the grid component to separate it from the main query, so we can have multiple grids on one page
  • Show the user's patterns in a grid (if any)
  • Show the user's favorites in a grid (if any)

My Patterns

In the design, there is one pagination, but two queries — should we show all owned patterns, and paginate favorites? or somehow paginate both? Or maybe we should create two pages after all, "my patterns" and "my favorites"?

What does the "featured" dropdown do in the favorites grid?

@shaunandrews
Copy link
Collaborator

there is one pagination, but two queries — should we show all owned patterns, and paginate favorites? or somehow paginate both? Or maybe we should create two pages after all, "my patterns" and "my favorites"?

My intention with the design was that each group would be it's own query, each with their own pagination. This is obviously not great, especially if we consider someone with more than a handful of both owned patterns and favorites. I think we should just split these up after all:

image

"My patterns" gets a button to create a new pattern, a filter for status, and a sort menu. "Favorites" has a category filter (maybe only show the categories that exist within the collection) and a sort menu.

What does the "featured" dropdown do in the favorites grid?

That's the "sort by" menu, which allows you to control the order of the items in the grid. In the context of "My patterns" and "Favorites" I think the options should be date (last updated), views, and favorites. The featured option doesn't really make sense on these screens.

@ryelle
Copy link
Contributor

ryelle commented Jul 7, 2021

An issue was created for the favorites page - #239. The remaining task for this issue is the management dropdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme The frontend of the pattern directory, pattern lists UI [Type] Tracking Issue
Projects
None yet
Development

No branches or pull requests

8 participants