Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log changes to patterns #57

Closed
coreymckrill opened this issue Mar 30, 2021 · 3 comments · Fixed by #432
Closed

Log changes to patterns #57

coreymckrill opened this issue Mar 30, 2021 · 3 comments · Fixed by #432
Assignees
Labels
[Component] Pattern Directory The backend of the pattern directory: submission, management, etc

Comments

@coreymckrill
Copy link
Contributor

There are probably several reasons why we'd want to be able to audit changes made to a pattern. One is so we can see who removed a pattern from the directory, when they did it, and why, if they include a reason.

A log entry should have a date, user name, type of change, and an optional comment. It might look something like this:

Date User Action Comment
2021-03-30 11:05:05 matt Submitted
2021-03-30 11:05:45 patternbot Flagged for manual review Possible copyright issue
2021-03-30 15:21:03 admin Approved Looks ok
2021-03-30 15:22:02 someotheruser Flagged for manual review Inappropriate content
2021-03-30 16:38:55 admin Removed Content is inappropriate

Log entries could be added both by automated processes (by "patternbot" or something) or by user-driven actions. In some cases the comment field could get populated automatically with pre-determined values. In other cases, like when a moderator is manually changing the status of a pattern, a textarea field should be available to add a reason, which would then get added to the log's comment field.

@coreymckrill coreymckrill added the [Component] Pattern Directory The backend of the pattern directory: submission, management, etc label Mar 30, 2021
@coreymckrill coreymckrill mentioned this issue Mar 30, 2021
7 tasks
@ryelle ryelle added this to the Initial Launch milestone Mar 30, 2021
@coreymckrill coreymckrill self-assigned this Jul 12, 2021
@coreymckrill coreymckrill added the [Status] Blocked Progress is blocked, and needs team input to move forward label Jul 12, 2021
@coreymckrill
Copy link
Contributor Author

Planning to use the Stream plugin for logging changes, so this is pending the merge of one of these PRs:

For the "adding a reason part" work is in progress on an "Internal Notes" plugin.

Logging changes isn't critical for the initial launch, so I changed the milestone on this one to Pattern Creation instead.

@coreymckrill
Copy link
Contributor Author

Development on the Stream plugin seems stalled, I haven't gotten any further responses on my PRs. I suspect we will need to write our own connector for post changes if we still want to use the plugin.

@tellyworth tellyworth self-assigned this Oct 11, 2021
@kasparsd
Copy link

The xwp/stream#1264 pull request has been merged and will be included in the next version of Stream.

@coreymckrill coreymckrill removed the [Status] Blocked Progress is blocked, and needs team input to move forward label Mar 10, 2022
coreymckrill added a commit that referenced this issue Mar 14, 2022
This enables the new logging feature in the Internal Notes plugin for the Pattern post type, and adds some custom logging for when a pattern gets flagged and when flags are managed by moderators.

Fixes #57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Pattern Directory The backend of the pattern directory: submission, management, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants