-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add select for filtering the pattern directory #580
Comments
Note that the existing "Featured" category is not the same thing as this new "Curated" filter. Curated patterns should be available via the Pattern Explorer—but not necessarily within the "Featured" category. @ryelle detailed the conditions how this currently works via a |
The whole this is confusing 😣 So a few questions to try to clear up some of that… "Curated patterns should be available via the Pattern Explorer" — is that different from the patterns that are by-default loaded in core? With this question, I'm trying to decide if we actually need the new What is the purpose of the Featured category after this change, is it just a subset of curated patterns?
We'll want to fix this issue #581 to make sure wayfinding works without the context bar. This will also loose the nested context, for example when filtering inside an author: I'm not saying this to say we need to keep the context bar, just wanted to flag that change.
Confirming the options under the dropdowns:
|
Ah, sorry — these are the same thing.
I think "Filter by" would work fine here. |
Perhaps it's not needed? All curated patterns should be available inside WordPress. Eventually community patterns will as well, once there's a filter within the Pattern Explorer to select between curated and community. |
Re: Removing the context bar Just confirming is the pattern count on the right the pattern count of the active context (dropdowns + tab)? Assuming so, it kind of works on desktop but feels a bit separated from the final context, the tab. I'm also curious as to what that would look like on mobile. Thoughts? |
The filters & "Browse categories" bar would probably need to switch positions on mobile, since the filters are above the categories on larger screens, the order should match on both screen sizes (so that it matches source order for keyboard/switch nav). The current view has the sort after because it's technically after the menu. I think that would still be fine, just wanted to note it. |
@jasmussen Does your design also remove the context bar ("223 Gallery patterns.", "3 patterns by Wes Theron.", etc)? There's already a small bug(?) on mid-sized screens, from about 870px wide down to when the menu collapses (782px) - introducing the Wireframe category made the menu wrap: Adding another item to this row causes the wrap to start at 960px now. The row could wrap like this, or we could avoid the problem with @richtabor's solution. So there's some more implementation considerations… otherwise I don't have a strong opinion on either. I've tagged this issue as needs design feedback, just to mark that it's not ready to be implemented until a design direction is finalized. |
That's this context bar, correct? I think we can probably do better in a redesign, but for now the mockups I shared here are purely about the category bar and dropdowns, and don't touch any notices or otherwise. So they can stay as they are for now.
I guess Rich's design works better there. I'm happy to go with that so we unblock it and get this moving. CC: @fcoveram |
Yeah, that's right, and that's what I was thinking too (not touching the context bar until the redesign).
This also works for me, though it doesn't have the side-effect of fixing that menu wrapping bug :) |
Let's move forward with @jasmussen's mockup; it's the lowest effort. |
Sounds good to me. I like Francisco's mockup, however we know we'll want to revisit this entire site in a refresh, so there's no reason to block this work from happening now. |
Consolidating next steps for #395 and #542. Let's add a select control for filtering pattern results at a high level.
This will introduce "Curated" and "Community" top-level filters, where "Curated" patterns are hand-picked to be surfaced front-and-center on the Patterns Directory, and eventually within the Pattern Explorer via WordPress/gutenberg#44611.
Tasks
Visuals
The text was updated successfully, but these errors were encountered: