Pattern CPT: Add validation for the pattern metadata #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryelle
added
the
[Component] Pattern Directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds checks for the viewport, description, and pattern title.
See #22.
A pattern needs a title, but a draft can stay untitled, so the check for a title only applies if the pattern is or will be published. The viewport value should be between 800 - 2000 (this is arbitrary - the default is 1200 and probably shouldn't change for most patterns). The description has a max length of 360 characters. There's no minimum, since the default is an empty string, and nothing will break if there isn't a description.
To test:
Automated tests on this PR should pass.
You can also test by sending requests to
/wp-json/wp/v2/wporg-pattern/<ID>