Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patterns list table improvements #92

Merged
merged 5 commits into from
May 11, 2021
Merged

Patterns list table improvements #92

merged 5 commits into from
May 11, 2021

Conversation

coreymckrill
Copy link
Contributor

@coreymckrill coreymckrill commented Apr 30, 2021 •
edited
Loading

  • Add columns to the patterns list table for each of the related taxonomies.
  • Add a column to the patterns list table that shows how many pending flags a pattern has.
  • Enable filtering by status when viewing flags for only one pattern.

Refs #63

This doesn't cover the requirement listed in #63 to add a modal for giving a reason when changing a pattern's status.

Screenshots

pattern-list-table

flags-list-table

How to test the changes in this Pull Request:

  1. Add some flags to some patterns. See these testing instructions if Theme: Add a window to report pattern. #83 isn't merged yet.
  2. View the patterns list table.
  3. Try clicking the Has Flags view to see only patterns that have "pending" flags.
  4. Try clicking on one of the numbers in the Pending Flags column to view flags for just that pattern.
  5. Change the status of a few flags so you can see the view links at the top of the patterns list table change.

@coreymckrill
Set up customization for the patterns list table
50b2388 
* Move flags list table customizations to a separate file
* Add columns for patterns taxonomies
* Add column for pattern flags
@coreymckrill coreymckrill added the [Component] Pattern Directory The backend of the pattern directory: submission, management, etc label Apr 30, 2021
@coreymckrill coreymckrill self-assigned this Apr 30, 2021
@coreymckrill coreymckrill marked this pull request as ready for review May 11, 2021 00:42
@coreymckrill coreymckrill requested a review from ryelle May 11, 2021 00:43
ryelle
ryelle approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@ryelle ryelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New columns look good, and I like the improvements on the Pattern Flag table filters as well. 👍🏻

@coreymckrill coreymckrill merged commit eb293de into trunk May 11, 2021
@coreymckrill coreymckrill deleted the fix/63/pattern-list-table branch May 11, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryelle ryelle ryelle approved these changes

Assignees

@coreymckrill coreymckrill

Labels
[Component] Pattern Directory The backend of the pattern directory: submission, management, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coreymckrill @ryelle