-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude rel=nofollow links from prefetch/prerender #1142
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one small doc typo/suggestion. Also, the tests are complaining about your changes.
7936258
to
7ce9672
Compare
Co-authored-by: Adam Silverstein <adamjs@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one suggestion.
Co-authored-by: Barry Pollard <barrypollard@google.com>
Summary
WooCommerce has
rel=nofollow
on its Add to Cart buttons (which are often links instead ofbutton
elements). These links are not idempotent and they must be excluded from prefech/prerender.Fixes #1140
Relevant technical choices
Alternatively this could have excluded URLs that include the
add-to-cart
query parameter. However, this would seem to be overly-specific to WooCommerce. The issue WICG/nav-speculation#309 was opened by @tunetheweb to consider whetherrel=nofollow
links should be excluded by default as well, so that is what this PR is going with now as well.Eventually there may need to be a filter in addition to
plsr_speculation_rules_href_exclude_paths
which applies on the entire speculation rules array so that a plugin can add exclusions which are not URL-specific.Before
After