-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Generate additional mime types on upload #151
Conversation
Co-authored-by: Crisoforo Gaspar Hernández <hello@crisoforo.com>
# Conflicts: # modules/images/webp-uploads/load.php
@adamsilverstein We need to be careful here to not introduce this logic entirely on the server-side, to avoid timeouts. This relates to the enhancements from https://core.trac.wordpress.org/ticket/40439 - the additional sizes in the other format have to somehow be kicked off from the client-side, so that the server can take care of them through individual requests. |
@adamsilverstein Do we still need this PR to be open? I'm thinking it's probably somewhat of a duplicate of #147 which is being worked on now. |
Closing, this was an experimental PR. |
Summary
image_editor_output_formats
that returns the output formats and their order. The first type is used as the default output formatimage_editor_output_format
filter applies for the first mime type, which also creates a full sized image if not the dame mime type as the uploaded image.Usage
By default, this code will generate WebP and jpeg sub sizes for every uploaded image, with WebP as the default.
Fixes #
Relevant technical choices
Checklist
[Focus]
orInfrastructure
label.[Type]
label.no milestone
label.