Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WebP for uploads module #32
Add WebP for uploads module #32
Changes from 10 commits
2cdbd52
087fb18
1d613b8
6c434c1
9429e06
f0e8fec
4c17af6
ad35694
336da5e
fe536d2
2620b57
aa753c0
f2cc640
4b60267
da4a30c
5133658
8ad877e
b1e0a67
45ad216
331e540
f8c9e2f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be ideal to run this test against several PHP versions, some that support WebP and some that don't. That way we can validate that the filter is only applied when the system supports WebP.
this check may be overly defensive as I think we do a similar check in core before actually switching, but I thik still worth having.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Right now the test suite only runs on latest WordPress and PHP 7.4, maybe let's open a separate issue to evaluate what versions we should run on? We also need to decide in general which WordPress and PHP versions the plugin should support overall, so that could be discussed in the same issue.