Add action to lint JS files using lint-js script
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `npm scripts` and `wp-scripts` to lint JS files
felixarntz
reviewed
Dec 23, 2021
There was a problem hiding this comment.
@mitogh Great work! Only left a few small comments that should be quick to resolve.
.github/workflows/js-lint.yml
Outdated
| - trunk | ||
| # Only run if JS/JSON/Lint/NVM files changed. | ||
| paths: | ||
| - '.github/workflows/js-css-lint-test.yml' |
There was a problem hiding this comment.
This needs to be adjusted to the file name here js-lint.yml.
.github/workflows/js-lint.yml
Outdated
| - '.github/workflows/js-css-lint-test.yml' | ||
| - '**.js' | ||
| - '**.json' | ||
| - '**.scss' |
There was a problem hiding this comment.
Probably not necessary to include .scss files here since this is exclusively for JS linting?
.github/workflows/js-lint.yml
Outdated
| - trunk | ||
| # Only run if JS/JSON/Lint/NVM files changed. | ||
| paths: | ||
| - '.github/workflows/js-css-lint-test.yml' |
.github/workflows/js-lint.yml
Outdated
| - '.github/workflows/js-css-lint-test.yml' | ||
| - '**.js' | ||
| - '**.json' | ||
| - '**.scss' |
package-lock.json
Outdated
| "resolved": "https://registry.npmjs.org/wp-prettier/-/wp-prettier-2.2.1-beta-1.tgz", | ||
| "integrity": "sha512-+JHkqs9LC/JPp51yy1hzs3lQ7qeuWCwOcSzpQNeeY/G7oSpnF61vxt7hRh87zNRTr6ob2ndy0W8rVzhgrcA+Gw==", | ||
| "dev": true | ||
| }, |
There was a problem hiding this comment.
This seems like an unrelated, system-specific update? Can you revert that?
felixarntz
added
[Type] Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62
Adds an action to lint JS files only using
wp-scripts.