Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
picture
element support #73Add
picture
element support #73Changes from 77 commits
0d3484c
f29a491
81dfa5e
bca723c
5d7b562
f4abeed
89cf629
d4b710d
8b32473
1ebc2ec
74b66c8
c0bf335
b9624a0
d41a7f3
86602fb
a46ad9d
3ff5d6f
03f710f
0360efe
8c21fa2
cd6f975
3a93d76
48573af
ba366a9
7eeb3b8
d49e704
9bd5be8
25355a8
43f8533
21a3ad3
4b657a6
cf8a7a8
7d884ec
a934b0c
2d0b40b
14fd90f
42a4713
c99c92e
d8f3969
c5765a6
ae319e5
dd13dcc
4e16457
de05e79
6a9d7e5
1b10b5a
ddaa425
fab30c8
6b38a3b
2cb0d68
05fe45f
132c784
c0e0b25
ac26be0
e0a382d
0214583
0b7043e
06e4bf2
47304d4
45e8c4a
e49cc20
78f28f5
82c6f80
4818932
eccd446
5d60dd6
e473b92
5b687bc
f4042fe
49a9d4b
5f820d4
f2b6ea5
27be1c7
7a07e91
e0b584c
d2af184
ac46157
0aa496e
2e68884
e88caca
2d57e43
6d024de
7d5f911
86a03f2
70400c8
38edfdb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sites that don't support AVIF or WebP, if someone uploads an original in one of those formats, won't all the intermediate sizes be JPEG? If so, do we want this to result in using
picture
or would a simpleimg
element be preferred?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested with WebP support missing, but my expectation is that you shouldn't be able to upload a WebP image if your server doesn't support it. This may not be working correctly in the block editor currently, so for now I am referring to uploading in the media library. I'm not sure I have a test version of PHP that doesn't support WebP.
~98% of WordPress sites are on a host that supports WebP so this is an edge case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joemcgill - I created this follow up Issue to work on improving the settings screen in particular when WebP isn't supported.