Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue templates for bug reports and feature requests #88

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Issue templates for bug reports and feature requests #88

merged 3 commits into from
Jan 28, 2022

Conversation

eugene-manuilov
Copy link
Contributor

Addresses #68

@eugene-manuilov eugene-manuilov added [Type] Feature A new feature within an existing module Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Jan 13, 2022
@eugene-manuilov eugene-manuilov mentioned this pull request Jan 13, 2022
Closed
mitogh
mitogh requested changes Jan 13, 2022
View reviewed changes
Copy link
Member

@mitogh mitogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing some characters, other than that looks great.

.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
@eugene-manuilov @mitogh
Apply suggestions from code review
68aa546 
Co-authored-by: Crisoforo Gaspar Hernández <hello@crisoforo.com>
@jeffpaul
Copy link
Member

I would strongly recommend changing these to YML files to use the issue forms and help force some of the issue content we're wanting/needing. Examples here.

@felixarntz
Copy link
Member

@jeffpaul IMO we can still merge this as a starting point (better than not having any), but I like your idea - would you mind to open an issue about using YML files instead so we can discuss there and iterate?

@JustinyAhin
Copy link
Member

@jeffpaul IMO we can still merge this as a starting point (better than not having any), but I like your idea - would you mind to open an issue about using YML files instead so we can discuss there and iterate?

I can go ahead and create and issue and a draft PR @felixarntz

@eclarke1 eclarke1 linked an issue Jan 17, 2022 that may be closed by this pull request
Setup .github templates #68
Closed
@eclarke1 eclarke1 removed a link to an issue Jan 17, 2022
Setup .github templates #68
Closed
@felixarntz felixarntz merged commit abbd733 into trunk Jan 28, 2022
@felixarntz
Copy link
Member

@JustinyAhin Sounds great - could you follow up on this?

@tillkruss tillkruss deleted the feature/68-issue-templates branch March 7, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitogh mitogh mitogh approved these changes

@felixarntz felixarntz felixarntz approved these changes

Assignees
No one assigned
Labels
Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Feature A new feature within an existing module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eugene-manuilov @jeffpaul @felixarntz @JustinyAhin @mitogh